Re: mc-4.6.0-pre1 -- some (groff>=1.18 related) problems

["Andrew V. Samoilov" <sav bcs zp ua>]

Peter Breitenlohner wrote:
> Hi,
>
> I recently replaced our old mc version with mc-4.6.0-pre1 (on linux/gnu, no
> distribution -- not that this matters much) and encountered the following
> problems:
>
> 1. With groff >=1.18 nroff needs an additional option "-c", certainly
> for mc's internal viewer and most probably equally for the external pager.

Fixed in CVS tree.  You can download it from http://www.ibiblio.com/mc.

> 2. On our systems zip/unzip are installed in /usr/local/bin and not /usr/bin

Should be checked in configure.

> I have fixed both of these problems in a brute foce way by the attached
> patch mc-4.6.0-pre1-diffs, but of course both of these problems ought to be
> properly handled by configure. (I just wanted to avoid using autoconf, which
> often gets tedious whith differing autoconf versions).
>
> Note in particular, that nroff from groff<1.18 does NOT accept "-c", so
> this definitely must be tested by configure!
>
> 3. We always use --disable-nls since we don't care much for message
> translations. (Please don't misunderstand me: I know they are important, we
> just happen do not need them and therefore don't want to install them).
>
> But even with --disable-nls, the translated manpages get installed. I really
> think this should either be automatically disabled by --disable-nls or,
> preferably, there should be a separate configure option (e.g.
> --disable-nls-data or --disable-nls-man). Alternatively configure could detect the
> presence or absence of the apropriate directories (per language?) and install
> translated manpages to, say $(DESTDIR)/usr/man/ru/man1 if and only if
> /usr/man/ru/man1 already exists. Hopefully automake/autoconf will sooner
> or later find a standardized way to handle such questions, but for the
> moment a more simplistic approch would suffice.
>
> The attached patch mc-4.6.0-pre1-lang is my very limited and brute force
> approach to this question.

I solved problem with translated manual in more configurable way.
Now mc checks LINGUAS environment variable and removes manuals after 
instaling if LINGUAS is set and there is no such language in this variable.

--
Regards,
Andrew V. Samoilov

Index: configure.in
===================================================================
RCS file: /cvs/gnome/mc/configure.in,v
retrieving revision 1.316
diff -u -r1.316 configure.in
--- configure.in	11 Nov 2002 01:57:43 -0000	1.316
+++ configure.in	28 Nov 2002 15:17:04 -0000
@@ -551,6 +551,8 @@
 dnl Version for the RedHat package, without dashes
 RPM_VERSION=`echo $VERSION | sed 's/-//g'`
 AC_SUBST(RPM_VERSION)
+ALL_LINGUAS=${LINGUAS:-$ALL_LINGUAS}
+AC_SUBST(ALL_LINGUAS)
 
 if test -n "$use_smbfs"; then
   AC_CONFIG_SUBDIRS([vfs/samba])
--- doc/Makefile.am	Mon Sep 23 13:13:06 2002
+++ doc/Makefile.am	Mon Oct 21 12:18:27 2002
@@ -13,3 +13,9 @@
 
 mc.hlp: mc.1 $(srcdir)/xnc.hlp $(top_builddir)/src/man2hlp
 	- $(top_builddir)/src/man2hlp mc.1 $(srcdir)/xnc.hlp mc.hlp
+
+install-data-hook:
+	for lang in $(SUBDIRS); do \
+	    case " $(ALL_LINGUAS) " in *\ $$lang\ *);; *) (cd $$lang ; $(MAKE) uninstall);; \
+	    esac \
+	done