RE: midnight bug - feature request



Hello!

Could you please use "diff -u" for patches?  It can make them less
readable than the whole files, but at least it shows what you are
removing, not just what your are adding.  It's important to see to make
sure that you are not breaking something unintentionally.

In fact, I cannot apply your patch unless I know that you have made it
yourself, that you have looked at it, and you are sure that you didn't
make any unintended changes.  That's not sufficient, but it's required.
Nobody knows better than you what changes were intentional.

> /* move cursor to column 'column' */
> void edit_move_to_column (WEdit * e, long column)

If you used GNU indent on this function, then please check the flags -
they are documented in doc/DEVEL.  And by the way, here's the patch for
GNU indent 2.2.8 that fixes the space between "*" and "e".  indent thinks
it's multiplication, not a function declaration.

=======================================
--- src/indent.c
+++ src/indent.c
@@ -1039,7 +1039,7 @@ static exit_values_ty indent (
                     }
                 }

-                parser_state_tos->want_blank = true;
+                parser_state_tos->want_blank = !is_procname_definition;
                 break;

             case postop:                /* got a trailing ++ or -- */
=======================================

-- 
Regards,
Pavel Roskin



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]