Re: New version on mc-multiscreen-patch



On Thu, Feb 14, 2002 at 03:08:13PM +0200, Andrew V. Samoilov wrote:
> >* F12 behaviour repaired in editor, which was broken in v0.6
> 
> I complain about F12 in editor. "Save As" is useful feature.

It is still accessible through menu, anyway
We would loose uniformity if F12 will behave
another way in the editor.

> You puts your changes near CVS keywords again.
> Please move #ifdef DLGSWITCH before #ifdef HAVE_CHARSET
> in main.c.

Fixed (see v0.7.1)
 
> Don't hardcode debug filename in log_mc_handler.
> It can be new mc option.

Do you mean a compile-time or a run-time option?

> Use vfs_file_is_local() to determine file location
> in edit/editwidget.c:edit().  It will be best if somebody
> rewrite edit engine to use dir properly.  It might be
> set to mc_return_cwd() if directory is NULL and filename
> is not absolute.  It is not good idea to always concat
> dir and file - resulted filename may confuse users.
> 
> PATH_SEP and PATH_SEP_STR have to be used instead of '/'
> and "/".

It will be fixed soon.

-- 

Regards, Walery



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]