Re: patchfs, audio update

[Pavel Roskin <proski gnu org>]

Hello!

> This wasn't necessary at all.
>
> The problem was somewhere else: patchfs treated empty line as the diff
> boundary, so the size was broken. The fix was really simple.

Sorry, I don't understand why an empty line is not a diff boundary.  It's
not valid in diff, as far as I know.

> Pavel, could you apply the attached patch please, not Andrew's one.

Sorry, I don't like this approach.  My Perl is not very strong.  I'll
rather wait for consensus than take a side.  Besides, Andrew has CVS
access and uses it very responsibly.

It would be nice to put all complex patterns to variables in the beginning
if they are the same for "list" and "copyout".  See Automake source (file
automake.in) for an example.

Also, the lines with line numbers (hunk headers) don't have to end with
"@@".  "diff --show-c-function" puts the function name after the second
"@@":

@@ -172,6 +172,11 @@ void *capture(void *arg)

I think that "@@\n$" should be replaced with "@@" in both places.
Tested, works for me.  I'm not applying it to avoid conflicts, but keep it
in mind.

-- 
Regards,
Pavel Roskin