Re: Command line history button bugs?

[Pavel Roskin <proski gnu org>]

Hello, David!

> It's a good thing to read help and manuals. I always wanted to know what
> the [^] thing at the right bottom corner of the screen was. I have
> disabled the keybar and in such way it seems that the button is useless.
> 
> Apart from that, the button has a weird behavior when switching things
> on and off. It moves one space left so the ] thing stays there twice or
> when you open the editor.

I confirm this bug.  The fix is fairly simple.  I believe that there was a
reason behind this "-1" - some terminals don't allow to use the lower
right corner.  But modern versions of S-Lang and ncurses should take care
of it.

========================
--- widget.c
+++ widget.c
@@ -2237,7 +2237,7 @@ buttonbar_callback (Dlg_head *h, WButton
 	    return 1;
 	widget_move (&bb->widget, 0, 0);
 	attrset (DEFAULT_COLOR);
-	printw ("%-*s", bb->widget.cols - 1, "");
+	printw ("%-*s", bb->widget.cols, "");
 	for (i = 0; i < COLS/8 && i < 10; i++){
 	    widget_move (&bb->widget, 0, i*8);
 	    attrset (DEFAULT_COLOR);
========================


> b) With hidden keybar, that button is useless. It seems to me that the
> keybar is still getting all mouse events.

I've applied a more radical patch that makes the invisible button bar 0
lines high, so that it doesn't get any mouse events.  Thank you for your
patch anyway, it has saved me some time.

========================
--- layout.c
+++ layout.c
@@ -700,7 +700,7 @@
 	    widget_set_size (&the_prompt->widget, LINES, COLS, 0, 0);
     }			     
 
-    widget_set_size (&the_bar->widget, LINES-1, 0, 1, COLS);
+    widget_set_size (&the_bar->widget, LINES-1, 0, keybar_visible, COLS);
     the_bar->visible = keybar_visible;
     
     /* Output window */
========================

-- 
Regards,
Pavel Roskin