Re: Filtered view (M!) works again

Hi, Pavel!

On Wed, Nov 14, 2001 at 03:33:38PM -0500, Pavel Roskin wrote:

> Hi, Andrew!
> On Thu, 8 Nov 2001, Andrew V. Samoilov wrote:
> > Hi, Pavel!
> > 
> > This patch makes "Filtered view" (M-!) feature work again
> > and fixes memory leak.  It was broken recently with file
> > type checks.
> Thank you and sorry that I broke it.
> I'm sorry for the late reply.  I didn't realize that you haven't applied
> your patch yet.  I'm applying it now with a small warning fix (gcc wrongly
> thinks that fd may be uninitialized).

Well, it was a reason I did not commit this patch.  Unfortunately
it really can be used uninitialized.  There is at least one place
(in layout.c, quick view) where view_init called 
with command => NULL and file => "".  Another unpleasant discovery was:
mc_open ("", ...) and mc_stat ("", ...) operate with current directory
and return usually someting but not -1.

> > P.S. Some days ago I mailed --enable-largefile vs smbfs
> > is fixed.  It is not so.
> > sizeof (off_t) == 8 in MC but 4 in samba.  
> Please feel free to fix samba support.

It seems it is more easy to rewrite it from scratch with 
libsmbclient URL syntax: 
smb://[[[domain;]user[:password ]]server[/share[/path[/file]]]]
and other good stuffs.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]