Re: Shouldn't LIBXMLCPP_EXCEPTIONS_ENABLED be defined?

[Murray Cumming <murrayc murrayc com>]

On Thu, 2012-04-12 at 09:27 +0200, Kjell Ahlstedt wrote:
> After the --disable-api-exceptions configure option was removed (commit 
> 81fead80bc5d0cc6f6188fd2d0f883def0e9a01e), LIBXMLCPP_EXCEPTIONS_ENABLED 
> is not defined in libxml++/config.h.
> 
> Application programs that contain code such as
> 
>    #ifdef LIBXMLCPP_EXCEPTIONS_ENABLED
>    try
>    {
>    #endif //LIBXMLCPP_EXCEPTIONS_ENABLED
>      .........
>      .........
>    #ifdef LIBXMLCPP_EXCEPTIONS_ENABLED
>    }
>    catch (const xmlpp::exception& ex)
>    {
>      std::cout << "Exception caught: " << ex.what() << std::endl;
>    }
>    #endif //LIBXMLCPP_EXCEPTIONS_ENABLED
> 
> will not catch exceptions.
> 
> Compare e.g. glibmm. glibmm/configure.ac contains
>    AC_DEFINE([GLIBMM_EXCEPTIONS_ENABLED],[1], [This is always set. This 
> is only for backwards compatibility.])
> and GLIBMM_EXCEPTIONS_ENABLED is defined in glibmm/config.h.
> 
> Shouldn't libxml++/configure.ac contain
>    AC_DEFINE([LIBXMLCPP_EXCEPTIONS_ENABLED],[1], [This is always set. 
> This is only for backwards compatibility.])
> until the next API break?

Yes, you are right. Please push that change.

-- 
Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com