Re: [libxml++] CVS: TextReader constructor change
- From: Murray Cumming <murrayc murrayc com>
- To: Nate Nielsen <nielsen memberwebs com>
- Cc: libxml++ <libxmlplusplus-general lists sourceforge net>
- Subject: Re: [libxml++] CVS: TextReader constructor change
- Date: Fri, 01 Dec 2006 18:07:20 +0100
On Fri, 2006-12-01 at 17:00 +0000, Nate Nielsen wrote:
> Murray Cumming wrote:
> > I'd prefer just to add another constructor for this if it's really
> > necessary. And size_t is usually unsigned, I believe, so it doesn't seem
> > wise to give -1 a special meaning.
>
> Hmmm, maybe I'm missing something, but....
>
> That's exactly what this change did. My original commit (and approved
> patch on bugzilla) erroneously gave a size of -1 a special meaning even
> though it was unsigned.
>
> This second patch fixed that up and removed the dumb -1 stuff.
Ah, sorry. I guess I would have understand if it had been explained a
bit more in the ChangeLog.
Sorry for the confusion.
--
Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]