Re: [libxml++] Document interface

[Christophe de VIENNE <cdevienne alphacent com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Vendredi 26 Septembre 2003 16:12, Murray Cumming Comneon com a écrit :
> > From: Christophe de VIENNE [mailto:cdevienne alphacent com]
> > Le Vendredi 26 Septembre 2003 15:28,
> >
> > Murray Cumming Comneon com a écrit :
> > > > From: Christophe de VIENNE [mailto:cdevienne alphacent com]
> >
> > That make sense. But shouldn't other functions be virtual too
> > ? I mean this
> > argument is true for the other interface I think.
>
> By my rationale, yes, and I have not done that throughout. But it's not a
> big deal, so do what you like.

So the decision is "wait and see"...

>
> Actually, in this case, that method probably was polymorphic once, but
> maybe isn't any more.
>
> > At least for write_to_stream, I'd prefer to do the following :
> > remove virtual for write_to_stream and
> > write_to_stream_formatted, and have it
> > only for do_write_to_stream. This is cleaner I think.
> > And for interface consistency we should do it also for the
> > other write_to
> > functions.
>
> There is logic in that.

It's done. Another advantage is that we don't have functions with almost the 
same implementation anymore.

All the examples run correctly, I will do more complete testing this afternoon 
but I think it's ok.


Cheers,

Christophe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/dFNJB+sU3TyOQjARAv0HAJ9W9dcawZ/GWqsfpexe9QHYKKbsagCfTHA3
mk00Jv73sQy5NSvQuRUMvT0=
=9q1t
-----END PGP SIGNATURE-----