RE: [libxml++] Document interface



> From: Christophe de VIENNE [mailto:cdevienne alphacent com] 
> Le Vendredi 26 Septembre 2003 15:28, 
> Murray Cumming Comneon com a écrit :
> > > From: Christophe de VIENNE [mailto:cdevienne alphacent com]
> That make sense. But shouldn't other functions be virtual too 
> ? I mean this 
> argument is true for the other interface I think.

By my rationale, yes, and I have not done that throughout. But it's not a
big deal, so do what you like.

Actually, in this case, that method probably was polymorphic once, but maybe
isn't any more.

> At least for write_to_stream, I'd prefer to do the following :
> remove virtual for write_to_stream and 
> write_to_stream_formatted, and have it 
> only for do_write_to_stream. This is cleaner I think.
> And for interface consistency we should do it also for the 
> other write_to 
> functions.

There is logic in that.

Murray Cumming
murrayc usa net
www.murrayc.com




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]