Re: [libxml++] [PATCH] clear_internal_subset()



>  - Why returning a bool ? I think only the post-condition of the function
> is important, which is always the same : no subset in the current document.
> If one needs to know if a subset was present before, then he should check
> it before. Otherwise if the absence of an internal subset is considered as
> an error, then it should throw an exception (I don't think so).

Ok, it can be removed.

>  - I don't know if the implementation is correct (I seems to me that yes
> but still). If nobody gives you a clear answer on this list, I'd suggest
> you to ask on the libxml list.

Hmm, looks like I have to try my luck there.

>  - I'd prefer you to use the patch manager next time. Thanks !

Ok, sorry, next time.

One other thing: Is there an easy way to get rid of the error output
to stderr if a parser error occures (f.e. when I use binary garbage as input)?

Cheers,
Thomas





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]