Re: [libxml++] [PATCH] clear_internal_subset()

[Christophe de VIENNE <cdevienne alphacent com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Thanks for the patch.

A few little comments :
 - Why returning a bool ? I think only the post-condition of the function is 
important, which is always the same : no subset in the current document. If 
one needs to know if a subset was present before, then he should check it 
before. Otherwise if the absence of an internal subset is considered as an 
error, then it should throw an exception (I don't think so).
 - I don't know if the implementation is correct (I seems to me that yes but 
still). If nobody gives you a clear answer on this list, I'd suggest you to 
ask on the libxml list.
 - I'd prefer you to use the patch manager next time. Thanks !


Regards,

Christophe

Le Mardi 9 Septembre 2003 10:13, Thomas Jarosch a écrit :
> Hi,
>
> I wanted to replace a dtd reference in a parsed document with a new one.
> Just calling set_internal_subset doesn't work, libxml checks if we already
> have at dtd and breaks.
>
> So I wrote the clear_internal_subset function.
>
> But since I haven't done much libxml hacking yet, I'm not sure if I got all
> the node linking, referencing and memory allocating right. I would highly
> appreciate it if a libxml guru could take a look at it.
> Feel free to include this patch to libxml++.
>
> Kind regards,
> Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/XZUxB+sU3TyOQjARAkypAKCJaVeKKv0tVRmRrwdYRhdtgIrWzACgrJvc
iFZIUDo7zL1/1W4QGHeCq34=
=JveW
-----END PGP SIGNATURE-----