Re: [libxml++] node iterators



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Vendredi 23 Mai 2003 17:00, Jonathan Wakely a écrit :
>
> Putting my pedant's hat on for a minute I'd mention that the comments
> say you must overload the callback, but this should be "override".
> Overloading refers to reusing the name for a function with a different
> signature, but to override a virtual you must be definition have exactly
> the same signature (covariant returns excepted).

Shame on me !  :-/

> I've submitted a patch so I can sleep soundly at night.  ;-)

It's in. Thx. Have a nice sleep :-)

> I'll update my source at home and submit a new patch if it's complete
> enough, then it can be included or not as you see fit.

Ok. (Remind the ChangeLog before submiting it).

Christophe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+zj3kB+sU3TyOQjARAktjAKCYE1CrGwXjJvfhSHa3N+jueF9wcwCgy6MP
ITPY51F9rH9PffX814nFa7I=
=0cFb
-----END PGP SIGNATURE-----





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]