Re: Change of behaviour in rage requests



On So, 2013-08-18 at 11:20 -0400, Dan Winship wrote:
On 08/17/2013 11:06 AM, Jens Georg wrote:
On Sa, 2013-08-17 at 16:44 +0200, Jens Georg wrote:
in 2.24.2,

soup_message_headers_set_range (message->request_headers, 499, 0);

Let me rephrase that: 8524d46134 seems to cause that when I call
_get_headers on a message with above range, I get:

Ranges: 8247343456435003746 7811852299414626661

Can you provide some sample code showing exactly what you're talking
about? When I add that call, I see "Range: 499-0", which is what you'd
expect. (The function doesn't actually check that the range is valid.)

Sorry, I wasn't clear or rather confused by our test: _set_range(s)
works fine, get_ranges seems to be odd now. We do that range check in
GUPnP ourselves and have tests for this and the unit test that checks
this started to fail recently here:

https://git.gnome.org/browse/gupnp/tree/tests/gtest/test-context.c#n207

with code in gupnp-context.c handling this request:

https://git.gnome.org/browse/gupnp/tree/libgupnp/gupnp-context.c#n952

ranges[0].start > ranges[0].end does not seem to be "true" anymore.

Passes without 8524d, fails with 8524d. I'll try to make a smaller
example later.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]