Re: Status of unit tests?

[Tommi Vainikainen <tvainika gmail com>]

Dan Winship <danw gnome org> writes:
> On 10/28/2011 7:36 AM, Tommi Vainikainen wrote:
>> I was about to submit a patch to
>> https://bugzilla.gnome.org/show_bug.cgi?id=662806, but after testing a
>> patch I tried to run unit tests "make check". However in my run 19/22
>> tests fail even before my modifications. What I'm doing wrong?
>
> Well, generally providing the test output would be be useful for
> answering that question, but I'm guessing that the answer is "you're
> compiling libsoup from a week ago or more against glib master and so
> getting bitten by -DG_DISABLE_DEPRECATED". If you update to a newer
> libsoup checkout (or build against stable glib) it should work better.

I'm compiling against libglib2.0-dev 2.30.1-2 from Debian (experimental).
When I try to compile against commit
2ec9af5efab3410e40dc84ca37264b58878727e3 from Thu Oct 27 15:00:31 2011
+0200

For example if I try to run './coding-test -d' I get segmentation fault:

(coding-test:12495): GLib-GIO-CRITICAL **: g_initable_new_valist: assertion `G_TYPE_IS_INITABLE (object_type)' failed

Backtrace:

#0  0x00007fcb551ca8fb in load_ssl_ca_file (priv=0xf8c840) at soup-session.c:934
#1  0x00007fcb551cab93 in set_property (object=0xf8c820, prop_id=5, value=0x7fff561beba0, pspec=0xf82010) at soup-session.c:991
#2  0x00007fcb54bfcd61 in g_object_set_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#3  0x00007fcb54bfd7b7 in g_object_set () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#4  0x0000000000403b3f in soup_test_session_new (type=16294928) at test-utils.c:230
#5  0x000000000040263f in do_coding_test () at coding-test.c:107
#6  0x0000000000403415 in main (argc=2, argv=0x7fff561bef38) at
#coding-test.c:353

>From soup-session.c lines:
934			g_warning ("Could not set SSL credentials from '%s': %s",
935				   priv->ssl_ca_file, error->message);

The value of variable 'error' is 0x0, which causes the segmentation fault.

With the patch that was in my previous message, I still get failed tests
with following output from coding-test:

(coding-test:13746): GLib-GIO-CRITICAL **: g_initable_new_valist: assertion `G_TYPE_IS_INITABLE (object_type)' failed

(coding-test:13746): GLib-CRITICAL **: g_error_free: assertion `error != NULL' failed
GET /mbox, plain
GET /mbox, Accept-Encoding: gzip
GET /mbox, Accept-Encoding: gzip, plus trailing junk
GET /mbox, Accept-Encoding: gzip, with server error
GET /mbox.gz, Accept-Encoding: gzip
GET /mbox.gz, Accept-Encoding: gzip, with server error

coding-test: 2 error(s).

In my analysis all errors for other tests are also from GLib assertions.

-- 
Tommi Vainikainen