Status of unit tests?
- From: Tommi Vainikainen <tvainika gmail com>
- To: libsoup-list gnome org
- Subject: Status of unit tests?
- Date: Fri, 28 Oct 2011 14:36:56 +0300
Hi,
I was about to submit a patch to
https://bugzilla.gnome.org/show_bug.cgi?id=662806, but after testing a
patch I tried to run unit tests "make check". However in my run 19/22
tests fail even before my modifications. What I'm doing wrong?
Also when starting Epiphany with my self-compiled libsoup, it crashes in
initialization. I think following patch would fix that one, because
g_error_matches returns FALSE if error is NULL:
diff --git a/libsoup/soup-session.c b/libsoup/soup-session.c
index e46b19d..a29e9aa 100644
--- a/libsoup/soup-session.c
+++ b/libsoup/soup-session.c
@@ -930,7 +930,7 @@ load_ssl_ca_file (SoupSessionPrivate *priv)
if (priv->tlsdb)
return;
- if (!g_error_matches (error, G_TLS_ERROR, G_TLS_ERROR_UNAVAILABLE)) {
+ if (g_error_matches (error, G_TLS_ERROR, G_TLS_ERROR_UNAVAILABLE)) {
g_warning ("Could not set SSL credentials from '%s': %s",
priv->ssl_ca_file, error->message);
--
Tommi Vainikainen
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]