Re: [libcroco-list] minor: cr_declaration_destroy cleanup



>  I usually use "unified" diff format (diff -u/-Unn), but this patch is
>  easier to read in diff -C8 format: look at the two versions of
>  cr_declaration_destroy as a whole rather than looking at individual
>  additions/deletions/changes.

As an aside, I usually include the "-p" argument to diff, since it
also includes function names.

>  I can't remember whether g_free(NULL) has always been fine, but note
>  that libcroco's configure.in checks for glib >= v2, and I think
>  g_free(NULL) has been fine for at least a very long time.
>  glib documentation of g_free doesn't mention any version compatibility
>  issues.

g_free(NULL) has always no-op'd, so there's never a need to do
something silly like "if (p) g_free(p);"

Cheers,
Dom


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]