Re: [ANNOUNCE] libchamplain 0.6

[Jiří Techet <techet gmail com>]

On Sat, May 29, 2010 at 11:37, Tomaž Vajngerl <quikee gmail com> wrote:
> Hi,
>
> I rebuilded with memphis specifics included and it worked. A result
> from this is that now bindings for libchamplain are dependent on
> libmemphis vala bindings otherwise vala compilation won't work.
> Another remark is that in champlain-0.6.pc it doesn't state
> memphis-0.2 as a requirement which has the effect that
> "vala-gen-introspect" doesn't work unless this is added.
>
> The third patch includes the missing memphis types and other
> declarations. Please let me know if I forgot something or it is not
> working as supposed.
> It would be nice if someone makes a example with memphis rendering. :)
>
> Regards,
> Tomaž
>
> On Sat, May 29, 2010 at 1:02 AM, Łukasz Jernaś <deejay1 srem org> wrote:
>> On Tue, May 25, 2010 at 8:22 PM, Tomaž Vajngerl <quikee gmail com> wrote:
>>> Hi,
>>>
>>> Attaching additional patch with rebuilded gi and vapi with actual
>>> stuff added in 0.6 - except some libmemphis specifics.
>>
>> The bindings and the demo seem to work fine, apart from some minor
>> whitespace warnings in the first patch, can you work out the memphis
>> specifics also?
>>
>> /me would like to see a 0.6.1 release soon with the vala bindings...
>>
>> Regards,
>> --
>> Łukasz [DeeJay1] Jernaś
>>
>
> _______________________________________________
> libchamplain-list mailing list
> libchamplain-list gnome org
> http://mail.gnome.org/mailman/listinfo/libchamplain-list
>
>

I've just looked at your vala bindings support and I have a few comments:

1. There seems to be a misunderstanding how memphis support should be
done - it should be always possible to compile bindings with/without
support of memphis. Please look at the python bindings that I made the
way that it's possible to compile them with/without memphis support.
Also please see my answer here

https://bugzilla.gnome.org/show_bug.cgi?id=619908

to understand how memphis support is supposed to be checked by the
applications. For instance Emerillon shouldn't require that
memphis-enabled libchamplain is installed no matter what bindings are
used.

2. Is there any reason why the bindings are not generated during make?
I would prefer not to commit things that can be generated
automatically. I did it for 0.4 just as a quick patch but for 0.6 I'd
prefer the correct solution.

3. A more general thing related to bindings - am I right that the only
reason we need bindings for memphis is the MemphisRule structure that
is passed as an argument to champlain_memphis_tile_source_set_rule() ?
Are there any more places where memphis interface is visible to the
applications using libchamplain? If this is the only place then it
would be much better to have e.g. ChamplainMemphisRule structure that
is used instead of MemphisRule in libchamplain and which would hide
all the memphis interface so bindings will not have to be aware of
memphis. This would just eliminate the problem in (1). This would be
possible for libchamplain 0.7 only because it breaks the API
compatibility.

Thanks,

Jiri