Re: [jokosher-devel] [PATCH] Fixed bug #119700 and removed RecView/MixerStrip control button redundancy
- From: Laszlo Pandy <laszlok2 gmail com>
- Cc: jokosher-devel-list gnome org
- Subject: Re: [jokosher-devel] [PATCH] Fixed bug #119700 and removed RecView/MixerStrip control button redundancy
- Date: Sun, 24 Jun 2007 19:58:14 -0400
John Green wrote:
Not had the chance to give it a full whirl but at first glance this
looks spot on to me and fits in nicely with recent simplifications.
What do other people think?
Thanks Knut.
John
Just looking it over again I found something that needs to be changed.
See the part of the patch at the bottom. The UpdateInstrumentNames
function is not allowed to exist because that means it has to be
manually called each time the name is modified. We recently changed to
use the gobject system, and it should be used for all update methods.
The proper way to do this would be to attach a callback to the "name"
signal on the instrument object. There is already a callback in
InstrumentViewer called OnInstrumentName. The same should exist for
MixerStrip. The only reason it doesn't is because you completed this
patch before I had a change to convert MixerStrip to the gobject system.
That conversion includes removing the Update method (again, because
Updates are bad) and put in signal callbacks for each specific thing.
Since I've already implemented it in OnInstrumentName, it shouldn't be
hard to do the same for MixerStrip, but if you want me to make the
changes instead just let me know.
Laszlo
Index: Workspace.py
===================================================================
--- Workspace.py (revision 1430)
+++ Workspace.py (working copy)
@@ -84,6 +84,14 @@
self.mainview.compactMixButton,
self.mainview.mixingViewDisabledTip)
#____________________________________________________________________
+ def UpdateInstrumentNames(self):
+ """
+ Updates the instrument names in the MixerStrips.
+ """
+ for strip in self.mixView.mixerStripList:
+ strip.Update()
+ #____________________________________________________________________
+
#=========================================================================
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]