Re: [PATCHES] proxy monitor fixes + mount by device file



On Wed, 2009-02-25 at 22:32 -0500, David Zeuthen wrote:
> Hey,
> 
> Thanks for the review, an updated version is here
> 
> http://people.freedesktop.org/~david/gvfs-proxy-fixes-2.patch

Leftover spew:

+  g_warning ("z0");
+  res = g_volume_can_eject (G_VOLUME (proxy_shadow_mount->volume));
+  g_warning ("z1");

+      _("The operation was cancelled"));

Please use "Operation was cancelled" as its a currently used string and
we're in a freeze.

Otherwise it looks good to me.

> What about the other patch? (gvfs-mount-allow-device-file.patch)

That one is ok.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]