Re: [PATCHES] proxy monitor fixes + mount by device file

[Alexander Larsson <alexl redhat com>]

On Fri, 2009-02-20 at 17:30 -0500, David Zeuthen wrote:
> Hey,
> 
> Here are two patches. The first one is very simple, it teaches
> gvfs-mount about the --device (short -d) option so you can do things
> like this
> 
>         $ gvfs-mount -d /dev/sdb3 
>         The device "Generic STORAGE DEVICE" contains encrypted data on partition 3.
>         Password: 
>         Mounted /dev/dm-0 at /media/Encrypted Stuff
>         
> The other patch is, uh, a bit more complex. It's basically a huge set of
> fixes for the proxy monitor code. I needed all these fixes for the
> DeviceKit-disks/gnome-disk-utility volume monitor I'm working on. Here's
> a bonus screenshot of that

g_proxy_volume_mount()
 - if already canceled, leaks data
 - g_cancellable_is_cancelled() can handle cancellable == NULL, just
move
   this check to start of function
Same for other calls in drive, mount, etc
   
proxy volme/drive: mount_cancelled()/operation_cancelled()
This calls g_proxy_volume_monitor_get_dbus_connection() etc and may be
called on a thread.
Shouldn't it get the proxy lock?

proxy volume:
mount_cb and mount_cancelled can race if cancellation runs on another
thread
This is actually a bit hard to fix, we probably need some API in gio for
this, similar
to what you asked about before in the connect case. I'll look into this.
All you
should need to do is disconnect before starting to free data.

proxy volume: DBusOp->is_cancelled
Why do you need this, you can just look at g_cancellable_is_cancelled()
Same for drive/mount/etc

proxy volume:   
volume->hash_mount_op_id_to_data is leaked

Also, is it a good idea to send the password in clear text over the
session bus?