Re: [patch] three simple patches

[David Zeuthen <david fubar dk>]

On Mon, 2008-04-07 at 21:27 +0200, Christian Kellner wrote:
> Hey
> 
> 
> >  1. Add myself and my backends to the AUTHORS file. Dunno why they were
> >     missing.
> Please commit. Sorry, wasn't on purpose, I promise! (-: Also feel free
> to commit that also to stable.
> 
> >  2. Unbreak the gphoto2 backend. See the archives where consensus was
> >     reached that only for 2.22 the gphoto2 backend was to be disabled
> >     like this. Better get this into HEAD early.
> Yes, go ahead.
> 
> >  3. Add an --unmount-scheme option to gvfs-mount. This is primarily
> >     useful in wrappers for legacy programs not yet using gio. So for
> >     e.g. for gthumb or f-spot in F9 I was planning to use this for
> >     in exec wrapper. 

Committed these. Thanks.

> But see [1].
> Don't we just call exit () to do the "unmount". If so that could very
> well mess up something. I am going to look at the bug you filed after
> the release tomorrow. I will see to get the clean shutdown patch in
> after the release soon.

I think for Unmount() we do it correctly in the gphoto2 backend and let
the base class exit. Either way, if even we called exit(), gvfsd should
handle this (as in always giving back a reply) as a mount backend
process can terminate at any time. Right?

Cheers,
David