Re: [gupnp] [PATCH] Free the array allocated by xmlGetNsList()

["Zeeshan Ali (Khattak)" <zeenix gmail com>]

Hi,

On Thu, May 20, 2010 at 6:40 PM, Sven Neumann <s neumann raumfeld com> wrote:
> On Thu, 2010-05-20 at 15:28 +0300, Zeeshan Ali (Khattak) wrote:
>
>> > Turns out to be difficult to implement this without changing public API.
>> > We would have to add more parameters to
>> > gupnp_didl_lite_object_new_from_xml().
>>
>>   That is not public API so it's not an issue. The only public _new
>> methods are that of DIDLLiteWriter and DIDLLiteParser, all other
>> objects are created by use of methods in these objects which in turn
>> call the (internal) _new methods of object being created.
>
> Ah, I didn't realize that. I tend to mark internal functions that are
> not static with a leading underscore and somehow assumed that this
> convention would be used here as well.

  NP. :)

> Will try to come up with a patch
> tomorrow then.

  Cool.

> You might want to mark gupnp_didl_lite_object_new_from_xml() with
> G_GNUC_INTERNAL so that it isn't exposed as a public method in the
> library.

   Sure, I thought they already are.

>Also gupnp_didl_lite_container_new_from_xml() should probably
> be removed. It doesn't seem to be called from anywhere and isn't even
> prototpyed.

  Yikes, that was supposed to be removed along with
gupnp_didl_lite_item_new_from_xml().

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124
--
To unsubscribe send a mail to gupnp+unsubscribe\@o-hand.com