Re: [gupnp] [PATCH] Free the array allocated by xmlGetNsList()


On Wed, May 19, 2010 at 7:26 PM, Sven Neumann <s neumann raumfeld com> wrote:
> Hi,
> apart from the memory leak, which is fixed by the patch that I just
> submitted, it appears to be somewhat inefficient to parse the list of
> namespaces for each object that is added.
> So what I suggest is that GUPnPDIDLLiteWriter passes the two needed
> namespace references to the GUPnPDIDLLiteObject on object creation
> instead of having each object looking them up in the array of
> namespaces. Would you accept a patch that does this?

  If you pass it the same way the doc/node is passed, sure! :)


Zeeshan Ali (Khattak)
FSF member#5124

P.S. Not really a big deal if you submit a few patches but if there is
going to be more patches from you, I strongly suggest you follow the
first paragraph of 'DISCUSSION' section of `man git commit`.
To unsubscribe send a mail to gupnp+unsubscribe\

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]