Re: [gupnp] [PATCH] Free the array allocated by xmlGetNsList()

["Zeeshan Ali (Khattak)" <zeenix gmail com>]

Hi,

On Thu, May 20, 2010 at 11:05 AM, Sven Neumann <s neumann raumfeld com> wrote:
> On Wed, 2010-05-19 at 20:19 +0300, Zeeshan Ali (Khattak) wrote:
>> On Wed, May 19, 2010 at 7:26 PM, Sven Neumann <s neumann raumfeld com> wrote:
>> > apart from the memory leak, which is fixed by the patch that I just
>> > submitted, it appears to be somewhat inefficient to parse the list of
>> > namespaces for each object that is added.
>> >
>> > So what I suggest is that GUPnPDIDLLiteWriter passes the two needed
>> > namespace references to the GUPnPDIDLLiteObject on object creation
>> > instead of having each object looking them up in the array of
>> > namespaces. Would you accept a patch that does this?
>>
>>   If you pass it the same way the doc/node is passed, sure! :)
>
> Turns out to be difficult to implement this without changing public API.
> We would have to add more parameters to
> gupnp_didl_lite_object_new_from_xml().

  That is not public API so it's not an issue. The only public _new
methods are that of DIDLLiteWriter and DIDLLiteParser, all other
objects are created by use of methods in these objects which in turn
call the (internal) _new methods of object being created.


-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124
--
To unsubscribe send a mail to gupnp+unsubscribe\@o-hand.com