Re: [gupnp] enable gzip compression for action responses

["Zeeshan Ali (Khattak)" <zeenix gmail com>]

Hi,

On Mon, Jun 21, 2010 at 3:32 PM, Sven Neumann <s neumann raumfeld com> wrote:
> On Mon, 2010-06-21 at 15:21 +0300, Zeeshan Ali (Khattak) wrote:
>
>> > I think I'd be happiest with version checks and conditional enabling.
>>
>>   I think we can just bump the deps since even libsoup 2.30 is already
>> in distros. Same goes for glib since you are not bumping it beyond
>> 2.24?
>
> libsoup 2.28.2 and glib 2.24.0 are the requirements for this patch.

  Then I will vote for a simple version bump.

>>   Can't this be on demand somehow? i-e only compress if client asks
>> for compression?
>
> It is on-demand, of course. Only if the client sets the
> "Accept-Encoding" header in the action call will the response be
> encoded. But the patch currently sets this header unconditionally for
> all actions. IMO it does not make sense to allow to enable/disable this
> on a per-action basis. But it might make sense to enable/disable it
> globally for a particular GUPnP context.
>
> There is a tradeoff between CPU usage and bandwidth usage here.
> Compression dramatically reduces the bandwidth that is being used, but
> it puts some burden on the CPU of the server and the client. On a device
> with very limited CPU resources that is connected over ethernet, using
> compression might even result in a slight slow-down.

  Ah ok! in that case, my suggestion would be the same as that of Ross.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124
--
To unsubscribe send a mail to gupnp+unsubscribe\@o-hand.com