|
Thanks for looking at it for me. I
knew the web links in the code were wrong. Those will probably
the same as for the rest of the poppler project, but I have to
talk to the poppler devs about that. Many of your other comments
were quite helpful. If you see anything else let me know.
Glenn
On 12/23/2012 08:57 AM, Kjell Ahlstedt wrote:
2012-12-19 18:32, Glenn Rice skrev:
I have written a poppler-glibmm wrapper for poppler-glib via
mmproc, and I was wondering if someone who is familiar with
wrapping glib libraries in this way could take a look at what I
have done and check for common pitfalls. Also any suggestions
for improvement would be welcome. The code is available in a
git repository at
git://git.freedesktop.org/git/poppler/poppler-glibmm. The
repository is browsable via
http://cgit.freedesktop.org/poppler/poppler-glibmm/tree/
Thanks,
Glenn
You will find some comments in the attached file. I have browsed
the source code in poppler-glibmm/poppler-glib/src only very
quickly. (I haven't even opened all files.) I'm not
familiar with poppler-glib. It would have taken me a lot of time
to check if the classes and methods are correctly wrapped.
The attached file contains some questions. I don't expect answers
to those questions. They just show details that I don't know if
they are correct. They might well be correct.
Kjell
|
