Re: Request for review

On Tue, 2008-01-15 at 12:41 +0200, Naveen Verma wrote:
> Hi,
> I have attached the modified file, after bit more study
> and understanding. Could you please check it and give me comments?

You really need to "svn add" it in your glibmm svn checkout. Then it
will show up in an "svn diff".

Try changing the build files (Makefile_list_of_hg.am_fragement) so you
see the build errors.

> Although the comments are missing that which is one task which I will
> complete. 
> There are some minor doubts about data types like should we use glib
> guint8, guint32

Yes, use these directly. Only simple types (gchar, gint) should be
converted to e.g. char, int.

>  as such in glibmm or to convert in other format, same with using
> std::string or Glib::ustring

Use std::string for text data of unknown encoding. Use Glib::ustring for
text that is known to be UTF-8.

>   as per the doc we should use Glib::ustring for gchar* and
> std::string for file name but in the existing code the std::string has
> been used for many other types then just for file name. So for where I
> can check the clear mapping about data types? 
> Thanks for your kind help in advance.
> -Br
> Naveen
murrayc murrayc com

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]