Re: freeze-break: gtkmm RecentAction constructors

[Frederic Crozat <fcrozat mandriva com>]

Le lundi 10 septembre 2007 à 11:06 +0200, Murray Cumming a écrit :
> release-team, may I have an API-freeze break (or hard-code-freeze break,
> depending on when this break is approved) for the attached patch, which
> has this ChangeLog entry?
> 
> 2007-09-10  Murray Cumming  <murrayc murrayc com>
> 
> 	* gtk/src/recentaction.ccg:
> 	* gtk/src/recentaction.hg: Make the constructors use the same 
> 	parameter order as the other action classes. Remove the comment 
> 	about the default constructor, now that the GTK+ C documentation 
> 	is clearer in bug #450032.
> 	* gtk/src/action.hg:
> 	* gtk/src/radioaction.hg:
> 	* gtk/src/toggleaction.hg: Deprecate the default constructors, 
> 	because they cannot work. We could maybe remove them, but maybe 
> 	they are used in the build of some applications, but never used 
> 	at runtime.
> 	Added default values for the StockID parameters, now that we 
> 	know that we know that this is OK - see bug #450032.
> 
> 
> Gtk::RecentAction is a new class in gtkmm 2.12 and is unlikely to be
> used yet by any applications. Not committing this would leave us with a
> slightly confusing API that we couldn't change later.
> 
> The other changes (deprecation and adding default values) are more API
> additions than API breaks.

Approval 1 of 2, since it is a recent addition.

-- 
Frederic Crozat <fcrozat mandriva com>
Mandriva