Re: gstmm add element to pipeline test

[Murray Cumming <murrayc murrayc com>]

On Thu, 2007-12-06 at 12:48 -0500, José Alburquerque wrote:
> Murray Cumming wrote:
> > On Thu, 2007-12-06 at 12:31 -0500, José Alburquerque wrote:
> >   
> >> What happens is that the signal is only emitted once no matter how
> >> many 
> >> times add_signal_watch is called.  However, unless
> >> remove_signal_watch 
> >> is called the same number of times it appears that a reference to the 
> >> Bus is kept and the Bus will not be destroyed.
> >>     
> >
> > That does seem very odd and useless. I suggest that we just make sure
> > that we call remove_signal_watch() enough times in our destructor,
> > adding to a count whenever add_signal_watch() is called.
> >
> >   
> And keep the method names enable/disable_message_signal?

No, let's not change the method name.

>   Also, it seems 
> the destructor is not called unless the "signal watches" have been 
> removed first.  Maybe a boolean can tell whether the signal has been 
> enabled and then not have to call add_signal_watch any more.

Hmm, then I guess we must force the application developer to call
remove_watch(). Very unpleasant. I still don't think we understand
enough about this, but I'll happily apply a patch in the meantime.

-- 
murrayc murrayc com
www.murrayc.com
www.openismus.com