Re: AboutDialog url hook not working?

[Murray Cumming <murrayc murrayc com>]

On Tue, 2006-06-13 at 08:34 +0200, Murray Cumming wrote:
> The slot (or the useful part of it) seems to have been deleted, before the
> point at which the GTK+ callback tries to use it. Valgrind errors usually
> have two parts - where it went wrong, and where caused that.

Here's the culprit. I hate void*.


Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gtkmm/ChangeLog,v
retrieving revision 1.488
diff -u -p -r1.488 ChangeLog
--- ChangeLog	10 Jun 2006 22:42:09 -0000	1.488
+++ ChangeLog	13 Jun 2006 17:20:52 -0000
@@ -1,3 +1,8 @@
+2006-06-13  Murray Cumming  <murrayc murrayc com>
+
+	* gtk/src/aboutdialog.ccg: set_url_hook(): Pass the slot pointer
instead of a 
+	pointer to the slot pointer, so that this works again.
+
 2006-06-11  Murray Cumming  <murrayc murrayc com>
 
 	* gtk/src/assistant.hg: Added update_buttons_state().
Index: gtk/src/aboutdialog.ccg
===================================================================
RCS file: /cvs/gnome/gtkmm/gtk/src/aboutdialog.ccg,v
retrieving revision 1.4
diff -u -p -r1.4 aboutdialog.ccg
--- gtk/src/aboutdialog.ccg	11 May 2006 11:40:24 -0000	1.4
+++ gtk/src/aboutdialog.ccg	13 Jun 2006 17:20:52 -0000
@@ -76,7 +76,7 @@ void AboutDialog::set_url_hook(const Slo
   SlotActivateLink* slot_copy = new SlotActivateLink(slot);
 
   gtk_about_dialog_set_url_hook(
-      &SignalProxy_ActivateLink_gtk_callback, &slot_copy,
+      &SignalProxy_ActivateLink_gtk_callback, slot_copy,
       &SignalProxy_ActivateLink_gtk_callback_destroy);
 } 

-- 
Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com