Re: [PATCH] Defer the first framebuffer request to an idle event

["Daniel P. Berrange" <dan berrange com>]

On Sat, Jun 29, 2013 at 07:48:22PM -0300, Jonh Wendell wrote:
> From: Jonh Wendell <jonh wendell intel com>
>
> It seems the first framebuffer update request sometimes is
> not being correctly sent to the server.
>
> Delaying its execution to an idle event seems to fix that.

This is dubious.  The 'on_initialized' method is connected
to the 'initialize' signal on VncConnection. This signal
is triggered from do_vnc_connection_emit_main_context
which is run from an idle function already.

If this changes any behaviour, it seems like just luck to me.

So NACK to this patch unless there is some kind of explanation
as to why it it works and/or what the root cause problem is.

> https://bugzilla.gnome.org/show_bug.cgi?id=703326

I don't see the behaviour you describe in the bug there.
Connecting to a server with the 'gvncviewer' example
program, it immediately displays the remote desktop.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|