Re: [PATCH] Return GOptionEntry instead of GOptionGroup in VncDisplay

["Daniel P. Berrange" <dan berrange com>]

On Mon, Aug 10, 2009 at 04:16:23PM -0300, Jonh Wendell wrote:
> Hi, folks.
> 
> It's better for apps to get a GOptionEntry * than get a GOptionGroup.
> Thus, it's up to apps to integrate those options, returned by gtk-vnc
> into their own groups. This makes things flexible.
> 
> So, for instance, in vinagre, I create a group "VNC" and put into it
> both vinagre options and gtk-vnc options.
> 
> Comments?

Sounds like a reasonable idea, but we should not remove the existing
method. Simply  add a new vnc_display_get_option_entries(), but leave
the vnc_display_get_option_group() working as it is, otherwise all
existing apps break

Regards,
Daniel
-- 
|: http://berrange.com/     -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://freshmeat.net/~danielpb/    -o-   http://gtk-vnc.sourceforge.net :|