Re: [PATCH] Return GOptionEntry instead of GOptionGroup in VncDisplay
- From: Jonh Wendell <jwendell gnome org>
- To: "Daniel P. Berrange" <dan berrange com>
- Cc: gtk-vnc-devel List <gtk-vnc-list gnome org>
- Subject: Re: [PATCH] Return GOptionEntry instead of GOptionGroup in VncDisplay
- Date: Mon, 10 Aug 2009 17:32:36 -0300
Em Seg, 2009-08-10 às 20:30 +0100, Daniel P. Berrange escreveu:
> On Mon, Aug 10, 2009 at 04:16:23PM -0300, Jonh Wendell wrote:
> > Hi, folks.
> >
> > It's better for apps to get a GOptionEntry * than get a GOptionGroup.
> > Thus, it's up to apps to integrate those options, returned by gtk-vnc
> > into their own groups. This makes things flexible.
> >
> > So, for instance, in vinagre, I create a group "VNC" and put into it
> > both vinagre options and gtk-vnc options.
> >
> > Comments?
>
> Sounds like a reasonable idea, but we should not remove the existing
> method. Simply add a new vnc_display_get_option_entries(), but leave
> the vnc_display_get_option_group() working as it is, otherwise all
> existing apps break
>
> Regards,
> Daniel
Done. Just pushed this new symbol in git.
By the way, when are you going to release a new tarball? I need this new
function in a tarball for vinagre :)
Thanks,
--
Jonh Wendell
http://www.bani.com.br
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]