Re: [gtk-vnc-devel] [PATCH] remove plugin files in $(DESTDIR)

["Daniel P. Berrange" <berrange redhat com>]

On Tue, Oct 28, 2008 at 10:16:09AM +0100, Guido G?nther wrote:
> On Wed, Sep 17, 2008 at 01:44:54PM +0200, Guido Günther wrote:
> > Hi,
> > without this patch we're trying to remove files in the installed system:
> > 
> > /usr/bin/make  install-data-hook
> > make[4]: Entering directory `/build/buildd/gtk-vnc-0.3.7/build/plugin'
> > rm -f /usr/lib/mozilla/plugins/gtk-vnc-plugin.a /usr/lib/mozilla/plugins/gtk-vnc-plugin.la
> > rm: cannot remove `/usr/lib/mozilla/plugins/gtk-vnc-plugin.a': Permission denied
> > rm: cannot remove `/usr/lib/mozilla/plugins/gtk-vnc-plugin.la': Permission denied
> > make[4]: *** [install-data-hook] Error 1
> > 
> > (from http://experimental.debian.net/fetch.php?&pkg=gtk-vnc&ver=0.3.7-1&arch=ia64&stamp=1221522069&file=log&as=raw)
> > 
> > Please apply,
> >  -- Guido
> 
> > --- a/plugin/Makefile.am	2008-09-15 16:04:05.000000000 +0200
> > +++ b/plugin/Makefile.am	2008-09-16 21:22:12.000000000 +0200
> > @@ -21,7 +21,7 @@
> >  
> >  # Only leave the .so file in the plugins directory.
> >  install-data-hook:
> > -	rm -f $(plugindir)/gtk-vnc-plugin.a $(plugindir)/gtk-vnc-plugin.la
> > +	rm -f $(DESTDIR)$(plugindir)/gtk-vnc-plugin.a $(DESTDIR)$(plugindir)/gtk-vnc-plugin.la

ACK, makes sense.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|