Re: [gtk-vnc-devel] [PATCH 1/4] Use WIN32 instead of __MINGW32__
- From: "Daniel P. Berrange" <berrange redhat com>
- To: "Richard W.M. Jones" <rjones redhat com>
- Cc: gtk-vnc-devel lists sourceforge net
- Subject: Re: [gtk-vnc-devel] [PATCH 1/4] Use WIN32 instead of __MINGW32__
- Date: Thu, 30 Oct 2008 14:57:04 +0000
On Wed, Oct 29, 2008 at 03:01:39PM +0000, Richard W.M. Jones wrote:
>
> It's bad practice to use #if{,n}def __MINGW32__ sections unless the
> code really is MinGW-specific. (ie. Pretty unlikely).
>
> In fact, this code is Win32-specific, so use #if{,n}def WIN32 instead.
ACK, makes sense.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
