Re: [gtk-vnc-devel] critical error if scaling is on

[Jonh Wendell <jwendell gnome org>]

Em Seg, 2008-06-02 às 08:00 -0700, Rob Stoddard escreveu:
> I would suppose you are closing that connection after removing the 
> widget from its parent,  or removing something higher up from its 
> parent?  Regardless, this type of error happens when you try to call 
> gdk_gl_drawable_gl_begin on a widget that's not "currently shown."
> 
> 
> Regards,
> 
> Rob Stoddard

Thanks, Rob.

I just committed this patch, which fixes those messages.

Cheers,
-- 
Jonh Wendell
www.bani.com.br

# HG changeset patch
# User Jonh Wendell <wendell bani com br>
# Date 1212623896 10800
# Node ID dba0c3d837dd3f4455dd44154549892143be1978
# Parent  2396ceb7da50933e981f246a96c4a235eccee141
Fix an error message in destructor, when using scaling

diff -r 2396ceb7da50 -r dba0c3d837dd src/vncdisplay.c
--- a/src/vncdisplay.c	Sun Jun 01 13:42:07 2008 -0300
+++ b/src/vncdisplay.c	Wed Jun 04 20:58:16 2008 -0300
@@ -1680,7 +1680,7 @@ void vnc_display_close(VncDisplay *obj)
 	}
 
 #if WITH_GTKGLEXT
-	if (priv->gl_tex_data) {
+	if (priv->gl_tex_data && GTK_WIDGET_VISIBLE (widget)) {
 		gdk_gl_drawable_gl_begin(priv->gl_drawable,
 					 priv->gl_context);
 		glDeleteTextures(1, &priv->gl_tex);
@@ -1777,7 +1777,7 @@ static void vnc_display_finalize (GObjec
 	display->priv->gvnc = NULL;
 
 #if WITH_GTKGLEXT
-	if (priv->gl_enabled) {
+	if (priv->gl_enabled && GTK_WIDGET_VISIBLE (obj)) {
 		gdk_gl_drawable_gl_begin(priv->gl_drawable,
 					 priv->gl_context);
 		glDeleteTextures(1, &priv->gl_tex);