Re: [gtk-vnc-devel] PATCH: Fix co-routine shutdown / release

["Daniel P. Berrange" <berrange redhat com>]

On Mon, Jul 09, 2007 at 09:13:42AM -0500, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >When the co-routine shuts down we never call coroutine_release, so its
> >stack never gets unmapped. We also don't restore the 'current' pointer
> >to be the system coroutine. So if you later start a 2nd coroutine we're
> >switching state making the return state point to a now deleted coroutine.
> >All this makes the whole system very crash happy.
> >
> >So this patch does a couple of things:
> >
> >  - When the coroutine exits we call coroutine_release
> >  - When the coroutine exits we make the current context point to the
> >    system context
> >  - Ensures errors from swapcontext are passed back correctly, rather
> >    than return zero which indicates success.
> >
> >With this patch in place, I can now successfully connect to a VNC server,
> >disconnect, and then re-connect again without megadeath.
> >  
> 
> Nice catch!

Pushed this too.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|