Re: [gtk-vnc-devel] PATCH: fix keycode -> keysym conversions

["Daniel P. Berrange" <berrange redhat com>]

On Mon, Jul 09, 2007 at 09:12:01AM -0500, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >Since the VNC protocol only concerns itself with key up & down events, 
> >there
> >is no way to provide modifier key state to the remote server. For this 
> >reason
> >when converting from keycodes to keysyms prior to transmission, the client
> >must *not* apply modifier state. The exception is that the shift key should
> >be applied. The current code just sends the  keysym that GTK converted to
> >the server. The result is that pressing 'Alt' results in the server getting
> >a Alt Down, followed by  ISO_Prev_Group Up event - and so the Alt key is
> >forever 'stuck' down now.
> >
> >This patch re-runs the keycode -> keysym conversion, masking out all the
> >modifier keys except for Shift. This ensures matching key down & up events
> >get sent to the server, which then applies the modifier mapping itself.
> >  
> 
> Great, thanks!

This change is pushed now.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|