Re: [gtk-vnc-devel] [PATCH] Support for tight encoding

[Anthony Liguori <anthony codemonkey ws>]

Jonh Wendell wrote:
> Em Dom, 2007-12-30 às 23:00 -0600, Anthony Liguori escreveu:
>   
> > Hi,
> >     
>
> Hi, Anthony!
>
>   
> > The attached patch implements the tight encoding.  Tight turned out to 
> > require a bit more changes than ZRLE.  Perhaps the strangest thing 
> > requirement is jpeg decoding.  Instead of linking directly against 
> > libjpeg, I decide to make jpeg decoding a gvnc callback.  This lets 
> > VncDisplay implement jpeg decompression using GdkPixbuf.  jpeg support 
> > in tight is entirely optional so what we really should do in VncDisplay 
> > is detect whether GdkPixbuf supports jpeg and if not, disable jpeg support.
> >     
>
> A question: What the variable image is used for in
> gvnc_tight_update_jpeg() ?
>   

Ah, that's dead code.  I'll remove it.

> Another question: Right now is jpeg optional? I didn't see any test if
> GdkPixBuf supports jpeg, and didn't see any error handling in
> gvnc_tight_update_jpeg() if gvnc->ops.render_jpeg() returns FALSE.
>   

Right, it's not.  I will add that though before I commit it.  I need to 
think of the proper interface for setting encodings first though.

Regards,

Anthony Liguori

> > Tight is not well documented and I ran into a lot of problems getting 
> > the edge cases right so we'll really need to test this out.
> >     
>
> I've tested in Vinagre on a Ultravnc windows server and it went fine.
>   

> > I'm going to do a follow up patch to selectively enable/disabling 
> > encodings and also provide a mechanism to set the jpeg compression level.
> >     
>
> Great news!
>
>   
> > Regards,
> >
> > Anthony Liguori
> >     
>
> Thanks,
>