Re: Can't add new GTK 2.16 methods to GtkStyle

On Sun, Jan 18, 2009 at 9:55 PM, Torsten Schoenfeld <kaffeetisch gmx de> wrote:
muppet wrote:

Careful --- that will most definitely be a naming conflict with

   $style->get (...);    <- should that be Glib::Object::get() or
Gtk2::Style::get() ?

I tried to how the C++ and D bindings where doing with gtk_style_get
and gtk_style_get_property and they didn't implement it yet. I was
finding odd that no one implemented gtk_style_get yet, but I think
that this is a 2.16 method that not marked as 'since 2.16'. Can some
one confirm this?

The other method, Gtk2::Style::get_property(), also clashes with
Glib::Object. The question is whether this is acceptable in the same way as
it is acceptable for Gtk2::TreeModel::get(), i.e. are people more likely to
mean Gtk2::Style::get() rather than Glib::Object::get() when they call

Also, Emmanuel, I think it would make sense to let Gtk2::Style::get() and
get_property() be the same method (i.e. one is the alias of the other), and
to let that one method accept multiple arguments.  Just like
Glib::Object::get() and get_property() (in Glib/GObject.xs line 1257).

I have implemented Torsten's proposal.

Emmanuel Rodriguez

Attachment: GtkStyle.patch
Description: Text Data

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]