Re: [PATCH] fix POD generation with COPYRIGHT section in source

On Feb 18, 2009, at 10:57 AM, Torsten Schoenfeld wrote:

I think the problem occurs due to the "=for position COPYRIGHT" in xs/GnomeCanvas.xs. It's handled by Glib::GenPod::podify_pods() which means that the whole POD paragraph is returned, including the leading "=for" and the trailing "=cut". So we get a double "=cut" for modules with such a "=for position COPYRIGHT" directive[1].

Aha!  I knew i was missing something.

So, while not having your patch breaks for some modules, i imagine adding your patch might break for other modules.

Yeah. I think one solution would be to always output complete POD paragraphs with a trailing "=cut", instead of relying on one final "=cut". As in the attached patch. It fixes the Gnome2::Canvas problem while apparently not breaking anything else.

That looks good. Should we worry at all about trying to strip trailing =cuts embedded in user text?

The front of your fridge may be cheap and nasty, but I hope the next time you look at the back of your fridge, you'll regard it with suitable admiration.
  -- Tim Hunkin, "The Secret Life of Machines"

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]