Re: [PATCH] fix POD generation with COPYRIGHT section in source

[muppet <scott asofyet org>]

On Feb 13, 2009, at 8:03 PM, Ryan Niebur wrote:

> err, now it's attached.

> <fix-pod-generation-for-copyright.txt>

If i'm reading GenPod.pm correctly, then i don't think this is right.

xsdoc2pod() opens a whole bunch of sections, and the =cut is meant to  
close them all.  I see that the docs say "replace the generated  
COPYRIGHT section completely", but i don't think this is intended to  
mean "so you should add your own =cut".  In other words, i think it's  
wrong for the copyright text to include a =cut of its own.

In fact, i don't see a =cut in Gnome2::Canvas's Makefile.PL.

So, while not having your patch breaks for some modules, i imagine  
adding your patch might break for other modules.

Perhaps GenPod.pm should filter out any =cuts that it finds in your  
copyright strings?  Or maybe *shudder* use a state machine to keep  
track of whether we have written a =cut and write one at the end?

Ick.


DISCLAIMER:  i was only reading source, not actually running anything.


--
Me:  What's that in your mouth?
Zella:  *swallows laboriously*  Nothing.
Me:  What did you just swallow?
Zella:  A booger.
Me:  Baby girl, don't eat boogers.  That's gross.
Zella:  But it was in my nose.