Re: [PATCH] [REGRESSION] Gtk2::Notebook->append_page forbid undef labels

[muppet <scott asofyet org>]

On Tuesday, July 15, 2003, at 07:54  AM, Thierry Vignaud wrote:

> Thierry Vignaud <tvignaud mandrakesoft com> writes:
>
> > follow c api and allow to not pass label to
> > Gtk2::Notebook->append_page, thus fixing rfbdrake:
>
> but i still get the following error if i do not pass an extra undef
> ... :

ah, not an "extra" undef, but indeed the requested undef.  ...


> Uncaught exception from user code:
>         Usage: Gtk2::Notebook::append_page(notebook, child, tab_label)  
> at /usr/lib/libDrakX//ugtk2.pm line 125.
>          
> ugtk2::gtkappend_page('Gtk2::Notebook=HASH(0x86c2410)','Gtk2::Frame=HAS 
> H(0x86d348c)') called at ../../soft/rfbdrake/rfbdrake line 109
>         main::set_steps() called at ../../soft/rfbdrake/rfbdrake line  
> 50
> Use of uninitialized value in subroutine entry at  
> /usr/lib/libDrakX//c.pm line 10.
>
> any clue ?

while you allowed undef with _ornull, you didn't pass undef.  what you  
want is not only to allow undef, but to give it a default parameter of  
NULL, like this:

    void
    gtk_notebook_append_page (notebook, child, tab_label=NULL)
            GtkNotebook * notebook
            GtkWidget * child
            GtkWidget_ornull * tab_label

which would allow you to omit that last parameter and call

    $notebook->append_page ($frame)

as you wanted.

i posted a message a week or so ago asking for comments on changes to  
the API of these functions, specifically on difficulties in validation  
created by allowing various values for the label parameters, but have  
gotten no replies, so i have done nothing.