Re: [gtk-osx-users] gtk+3.10 on MacOSX 10.8.5 with Retina display

This patch fixed the problem.
I also noticed another issue.
The menu entries that are insensitive are not dimmed. When I click on such entry nothing happens, so they are made insensitive by code, just the color is not changed. Is this bug, or there is some changes how I should handle dimming? In 2.0.1 this was handled automatically.

From: John Ralls <jralls ceridwen us>
To: Andrius <andriusr yahoo com>
Cc: "gtk-osx-users-list gnome org" <gtk-osx-users-list gnome org>
Sent: Friday, October 11, 2013 12:16 AM
Subject: Re: [gtk-osx-users] gtk+3.10 on MacOSX 10.8.5 with Retina display

On Oct 10, 2013, at 2:00 PM, Andrius <andriusr yahoo com> wrote:

> Well, it did not work. The same crash at the same line...

Ah! I see it.

Try this:

diff --git a/src/cocoa_menu_item.c b/src/cocoa_menu_item.c
index 3f57f1f..5a9b0e2 100644
--- a/src/cocoa_menu_item.c
+++ b/src/cocoa_menu_item.c
@@ -692,14 +692,17 @@ cocoa_menu_item_add_submenu (GtkMenuShell *menu_shell,
      _GNSMenuItem *item = (_GNSMenuItem*)[cocoa_menu itemAtIndex: index];
      if ([item isSeparatorItem] &&
      (last_cocoa_item == nil || [last_cocoa_item isSeparatorItem]))
+    {
      [cocoa_menu removeItem: item];
+      continue;
+    }
      if (([item respondsToSelector: @selector (isMarked)]) && [item isMarked])
    [cocoa_menu removeItem: item];
      else if (![item isHidden])

John Ralls

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]