Re: ige-mac-integration

[Mikkel Kruse Johnsen <mikkel linet dk>]

Hi John

I tried to apply the patch from the bug report, but it do not apply to Gtk+-2.20.1 and was not easily changed.

You talked about a patch, did you push it or have it available somewhere to test ?

--
Med Venlig Hilsen / Kind Regards

Mikkel Kruse Johnsen Adm.Dir. Linet Ørholmgade 6 st tv Copenhagen N 2200 Denmark

Work: +45 21287793 Mobile: +45 21287793 Email: mikkel linet dk Web: Healthcare in: Professional Profile

Medical Consultant

tor, 09 09 2010 kl. 08:36 -0700, skrev John Ralls:
> On Sep 9, 2010, at 8:00 AM, Mikkel Kruse Johnsen wrote:
>
> > Hi John Ralls and Others
> > 
> > Thanks for the reply, I made a debug build and noticed that in GNSMenuItem.[c|h] there where a check for "#if MAC_OS_X_VERSION_MIN_REQUIRED > MAC_OS_X_VERSION_10_4" and it was using 10.4 code.
> > 
> > I tried to "export MACOSX_DEPLOYMENT_TARGET=1050" but it did not work. So I redefined it in the code and It do not crash anymore. Thanks.
> > 
> > I have two other problems:
> > 
> >     1) The menus don't use the Cmd-mac key as accel. I have set "gtk_osxapplication_set_use_quartz_accelerators" to true. But it's not working. It worked with the old implementation ?
> > 
> >     2) When I use "gtk_osxapplication_insert_app_menu_item" to move the "About" and "Preferences" MenuItem's to the Apple Menu. The Menu is still shown in the menubar even though the Menu is empty ?
>
> The correct way to set MAC_OS_X_VERSION_MIN is in your call to setup_sdk() in your jhbuildrc-custom. This is a build-time define, not a runtime variable.
>
> Unlike ige-mac-menu, GtkOSXApplication uses the Gtk+ accelerator map feature to redefine accelerators. This is documented in the GtkOSXApplication docs and demonstrated (and tested) in test-integration. Unfortunately, there's a regression in Gtk+ [1] which breaks accelerator handling for quartz in Gtk+-2.20.1 and later . I have a temporary patch which I will push today, along with a new release of ige-mac-integration.
>
> If you have a submenu that's empty it's up to you to hide the menuitem so that it doesn't display. There's no empty-menu detection in place.
>
> Regards,
> John Ralls
>
> 1: https://bugzilla.gnome.org/show_bug.cgi?id=607115