Re: [gtk-osx-devel] [PATCH] Run autoreconf before configuring liboil

[John Ralls <jralls ceridwen us>]

On Oct 5, 2012, at 9:20 AM, Christophe Fergeau <cfergeau redhat com> wrote:

> Without this, I was getting a weird libtool build failure on
> Lion. autogen-sh="autoreconf" cannot be used because of bgo #673202
> ---
> modulesets-stable/gtk-osx-gstreamer.modules   | 3 ++-
> modulesets-unstable/gtk-osx-gstreamer.modules | 4 +++-
> modulesets/gtk-osx-gstreamer.modules          | 4 +++-
> 3 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/modulesets-stable/gtk-osx-gstreamer.modules b/modulesets-stable/gtk-osx-gstreamer.modules
> index bab4931..b378175 100644
> --- a/modulesets-stable/gtk-osx-gstreamer.modules
> +++ b/modulesets-stable/gtk-osx-gstreamer.modules
> @@ -9,7 +9,8 @@
>   <repository type="tarball" name="sourceforge" 
>               href="http://downloads.sourceforge.net/sourceforge/"/>
> 
> -  <autotools id="liboil" autogen-sh="configure"
> +  <autotools id="liboil"
> +             autogen-template="autoreconf -fis &amp;&amp; %(srcdir)s/configure --prefix %(prefix)s --libdir %(libdir)s %(autogenargs)s"
> 	     makeargs=" CFLAGS=-DHAVE_SYMBOL_UNDERSCORE">
>     <branch repo="liboil" module="liboil-0.3.17.tar.gz" version="0.3.17" />
>   </autotools>
> diff --git a/modulesets-unstable/gtk-osx-gstreamer.modules b/modulesets-unstable/gtk-osx-gstreamer.modules
> index 823b059..2730318 100644
> --- a/modulesets-unstable/gtk-osx-gstreamer.modules
> +++ b/modulesets-unstable/gtk-osx-gstreamer.modules
> @@ -16,7 +16,9 @@
>        git://anongit.freedesktop.org/gstreamer/jhbuild/. The modules
>        are unversioned and haven't been tested for gtk-osx
>        compatibility, but there are more of them. -->
> -  <autotools id="liboil" makeargs=" CFLAGS=-DHAVE_SYMBOL_UNDERSCORE">
> +  <autotools id="liboil"
> +             autogen-template="autoreconf -fis &amp;&amp; %(srcdir)s/configure --prefix %(prefix)s --libdir %(libdir)s %(autogenargs)s"
> +             makeargs=" CFLAGS=-DHAVE_SYMBOL_UNDERSCORE">
>     <branch repo="liboil"  />
>   </autotools>
> 
> diff --git a/modulesets/gtk-osx-gstreamer.modules b/modulesets/gtk-osx-gstreamer.modules
> index 2554a12..bd423f9 100644
> --- a/modulesets/gtk-osx-gstreamer.modules
> +++ b/modulesets/gtk-osx-gstreamer.modules
> @@ -16,7 +16,9 @@
>        git://anongit.freedesktop.org/gstreamer/jhbuild/. The modules
>        are unversioned and haven't been tested for gtk-osx
>        compatibility. -->
> -  <autotools id="liboil" makeargs=" CFLAGS=-DHAVE_SYMBOL_UNDERSCORE">
> +  <autotools id="liboil"
> +             autogen-template="autoreconf -fis &amp;&amp; %(srcdir)s/configure --prefix %(prefix)s --libdir %(libdir)s %(autogenargs)s"
> +             makeargs=" CFLAGS=-DHAVE_SYMBOL_UNDERSCORE">
>     <branch repo="liboil" tag="liboil-0.3.17" />
>   </autotools>

Cristophe,

Sorry for being dense, but this doesn't make any sense to me. Liboil's repo has an autogen.sh, so why would you want to use autoreconf?  It also has no configure, so I don't see what 673202 has to do with anything. Finally, there's no patch to stable, so why run autogen *or* autoreconf?

Regards,
John Ralls