Re: [Gtk-osx-devs] FYI: proper synching of GtkRadioMenuItems



On Jun 22, 2010, at 2:43 PM, Richard Procter wrote:

> Hi,
> 
> My GtkRadioMenuItems were not maintaining the exactly-one-active  
> invariant in the OS X menubar. This was due to the integration code  
> synching via the notify::activate signal which GtkRadioMenuItem,  
> although a subclass of GtkCheckMenuItem, does not emit.
> 
> I have raised a bug http://bugzilla.gnome.org/show_bug.cgi?id=622260  
> with a tentative patch.
> 

Thanks for filing the bug and patch.

It's odd, though, because I have this specific test case (a pair of radiomenuitems) in testintegration.c and the synchronization works there, both in the MenuBar and in the Dock Menu.

I wonder though if it wouldn't be better for the radiomenuitem to chain its parent activate method (which would then properly call g_object_notify) rather than messing directly with the property (which belongs to the parent checkmenuitem, not the radiomenuitem). Oh, well. There seems to be a lot of that.

Regards,
John Ralls





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]