Re: glib/gdataset.c (quarky / stringy stuff)



On 20/10/2014 10:58, David Nečas wrote:
On Mon, Oct 20, 2014 at 10:39:54AM +0100, John Emmas wrote:
Is that change effectively equivalent to what I did locally?
No.  As far as I can tell you can pass NULL key to g_datalist_get_data()
after this change.  If you do so and g_quark_to_string(data->key)
returns NULL (for whatever reason), the two NULLs will be considered
equal by g_strcmp0().  Whereas your change makes a NULL not-equal to
everything, even another NULL.


Thanks guys for the very prompt replies. As it happens, a different issue has also arisen (following this morning's update) but I'll be sure to post that on the other mailing list! Best wishes,

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]