Re: On deprecating GtkTearOffMenuItem

[Stanislav Maslovski <stanislav maslovski gmail com>]

On Sat, Jun 05, 2010 at 11:33:53PM +0100, Emmanuele Bassi wrote:
> On Sat, 2010-06-05 at 15:33 +0400, Stanislav Maslovski wrote:
> 
> > How many LOC/bytes this change will save?
> 
> deprecation seldom has to do with lines of code or bytes saved; those
> are broken metrics.
> 
> the TearoffMenuItem has been proposed for deprecation because:
> 
>   • it's a broken user interaction metaphor, that just provides a way
> for the user to unbreak poorly designed applications;

This is nothing more then just a declaration. I do not see how it is
broken. Especially when compared to other _really_ broken interfaces
like GTK+ file open dialog. 

>   • it does complicate the code in GtkMenu because it has to handle the
> case where the menu window becomes a detached top-level under the window
> manager's domain.

With this I agree, but so far the related code worked okay, I have not
seen myself any bugs in it.

> >  Does it really makes a
> > considerable difference? Is the related code too complicated to
> > maintain (seems hard to believe)?
> 
> well, you should open gtk/gtkmenu.c some time. you'd find it easier to
> believe.

My point is if something is working okay, then why to break it? It can be
complicated, but if you do not need to change it, let it stay.

-- 
Stanislav